Skip to content

FOUR-25498 async functions don't work in the button control#1844

Merged
caleeli merged 6 commits into
epic/FOUR-25464from
FOUR-25498
Aug 4, 2025
Merged

FOUR-25498 async functions don't work in the button control#1844
caleeli merged 6 commits into
epic/FOUR-25464from
FOUR-25498

Conversation

@devmiguelangel

@devmiguelangel devmiguelangel commented Jul 31, 2025 •
edited by atlassian Bot
Loading

Copy link
Copy Markdown
Contributor

Issue & Reproduction Steps

Async functions don't work in the button control

Related Tickets & Packages

FOUR-25498

Code Review Checklist

  • I have pulled this code locally and tested it on my instance, along with any associated packages.
  • This code adheres to ProcessMaker Coding Guidelines.
  • This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
  • This solution fixes the bug reported in the original ticket.
  • This solution does not alter the expected output of a component in a way that would break existing Processes.
  • This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
  • This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
  • This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
  • This ticket conforms to the PRD associated with this part of ProcessMaker.

@devmiguelangel devmiguelangel self-assigned this Jul 31, 2025
@devmiguelangel devmiguelangel requested a review from caleeli July 31, 2025 19:19
@cypress

cypress Bot commented Jul 31, 2025 •
edited
Loading

Copy link
Copy Markdown

screen-builder    Run #1958

Run Properties:  status check failed Failed #1958  •  git commit 98d270eb80: FOUR-25498 async functions don't work in the button control
Project screen-builder
Branch Review FOUR-25498
Run status status check failed Failed #1958
Run duration 09m 12s
Commit git commit 98d270eb80: FOUR-25498 async functions don't work in the button control
Committer Miguel Angel
View all properties for this run ↗︎
Test results
Tests that failed  Failures 4
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 17
Tests that did not run due to a failure in a mocha hook  Skipped 17
Tests that passed  Passing 359
View all changes introduced in this branch ↗︎

Tests for review

Failed  DatePicker.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Date Picker > Date picker with minDate equal or less than first datepicker should return the current date Test Replay Screenshots
Failed  FormSelectList.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Form Select List > Validate duplicated option Test Replay Screenshots
Failed  FOUR6788_ScreenPerformanceTests.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
FOUR-6788 screen performance > Verify FOUR-6788 screen performance: select list, rich text Test Replay Screenshots
Failed  ComputedFieldsReadOnly.spec.js • 1 failed test • CI - Chrome

View Output

Test Artifacts
Computed fields > The user should not be able to change an input assigned to a sub property of a computed property Test Replay Screenshots

@processmaker-sonarqube

processmaker-sonarqube Bot commented Aug 1, 2025 •
edited
Loading

Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
37.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@caleeli caleeli changed the base branch from develop to epic/FOUR-25464 August 4, 2025 15:40
@caleeli caleeli merged commit a7a2bc8 into epic/FOUR-25464 Aug 4, 2025
5 of 10 checks passed
@caleeli caleeli deleted the FOUR-25498 branch August 4, 2025 15:45
@caleeli caleeli mentioned this pull request Aug 4, 2025
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@caleeli caleeli caleeli approved these changes

Assignees

@devmiguelangel devmiguelangel

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@devmiguelangel @caleeli